Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add errorprone check for immutables style collisions #1396

Merged
merged 8 commits into from
Jun 8, 2020
Merged

Add errorprone check for immutables style collisions #1396

merged 8 commits into from
Jun 8, 2020

Conversation

a10y
Copy link
Contributor

@a10y a10y commented Jun 8, 2020

Fix for #1395

@changelog-app
Copy link

changelog-app bot commented Jun 8, 2020 •
edited by a10y

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add errorprone check to avoid accidentally undoing immutables Style meta-annotations.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from ferozco June 8, 2020 18:48
@a10y a10y changed the title Save Add errorprone check for immutables style collisions Jun 8, 2020
carterkozak
carterkozak reviewed Jun 8, 2020
View reviewed changes
...ine-error-prone/src/main/java/com/palantir/baseline/errorprone/ImmutablesStyleCollision.java

@AutoService(BugChecker.class)
@BugPattern(
name = "ImmutablesStyleCollision",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document this alongside the other baseline error-prone checks in the readme!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to add it to the list of errorprone rules we always apply

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to the readme but where is the list @ferozco ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's just for automatic refactors, but this can't be auto-fixed. severity = BugPattern.SeverityLevel.ERROR, should be sufficient.

@carterkozak
Copy link
Contributor

lgtm pending readme update and changelog, thanks!

@ferozco
Copy link
Contributor

ferozco commented Jun 8, 2020 •
edited

Thanks @a10y !

@bulldozer-bot bulldozer-bot bot merged commit c87ba3b into develop Jun 8, 2020
@bulldozer-bot bulldozer-bot bot deleted the aduffy/style-meta branch June 8, 2020 19:47
@a10y a10y mentioned this pull request Jun 16, 2020
Closed
This was referenced Jun 22, 2021
Closed
Closed
Merged
Closed
Open
Merged
Merged
Merged
This was referenced Sep 15, 2021
Closed
Closed
Closed
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

@ferozco ferozco Awaiting requested review from ferozco

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a10y @carterkozak @ferozco