Added OptionalOrElseGetConstant error prone check. #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
ferozco
reviewed
Jun 11, 2020
...ne-error-prone/src/main/java/com/palantir/baseline/errorprone/OptionalOrElseGetConstant.java
Outdated
Show resolved
Hide resolved
Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
carterkozak
reviewed
Jun 11, 2020
...ne-error-prone/src/main/java/com/palantir/baseline/errorprone/OptionalOrElseGetConstant.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Jun 11, 2020
...ne-error-prone/src/main/java/com/palantir/baseline/errorprone/OptionalOrElseGetConstant.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Jun 11, 2020
...ne-error-prone/src/main/java/com/palantir/baseline/errorprone/OptionalOrElseGetConstant.java
Outdated
Show resolved
Hide resolved
* Excavator: Upgrade dependencies * correct task Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com> Co-authored-by: Robert Kruszewski <robertk@palantir.com>
Upgrade checkstyle to 8.33
Fix checkstyle config to conform to breaks made between 8.13 and 8.33
…/template.sh (#1384) Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com> Co-authored-by: forozco <forozco@palantir.com>
carterkozak
reviewed
Jun 12, 2020
carterkozak
reviewed
Jun 12, 2020
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/OptionalOrElseGetValue.java
Outdated
Show resolved
Hide resolved
StrictUnusedVariable handles Java 14 records
carterkozak
reviewed
Jun 12, 2020
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/OptionalOrElseGetValue.java
Outdated
Show resolved
Hide resolved
Wrap method declarations on parameters, not on modifiers and return type.
Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
…1418) Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
Adds the proper configuration files upon IntelliJ import of a gradle project for checkstyle and copyright. This generates the following additional files: - .idea/copyright/profiles_settings.xml - an xml file under .idea/copyright/ per copyright file under .baseline/copyright - .idea/checkstyle-idea.xml (and adds Checkstyle-IDEA to the external dependencies) if baseline-checkstyle is applied - Either .idea/codeStyleSettings.xml or a .idea/codeStyles/ folder with the contents being copied from .baseline/idea - If .baseline/idea/codeStyles is present, it will copy its contents, otherwise, it will fall back to .baseline/idea/intellij-java-palantir-style.xml as currently - The fallback is using a legacy IntelliJ format and requires closing and reopening the project to be taken into account
|
do we need to merge develop into this branch to pick up the unit-test-14 checks? |
carterkozak
approved these changes
Jun 17, 2020
…e into orElseGet-constant
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Lots of
Optional.orElseGet(() -> someConstant)floating around in the world.After this PR
==COMMIT_MSG==
Recommends using optional.orElse(constant) instead of optional.orElseGet(() -> constant)
==COMMIT_MSG==
Possible downsides?
None