check junit dependencies task can be skipped #1427
Conversation
Generate changelog in
|
| @@ -63,6 +71,17 @@ public final void validateDependencies() { | |||
| }); | |||
| } | |||
|
|
|||
| @Classpath | |||
| public final Provider<List<Configuration>> getConfigurations() { | |||
There was a problem hiding this comment.
I think gradle will get angry at you for using Provider<List<>> instead of ListProperty. If you want to have dynamic set of inputs you have to do it via getInputs() similarly to how you handle outputs
There was a problem hiding this comment.
this is using the same pattern as check unused dependencies. Propeties are differnet to providers, right?
There was a problem hiding this comment.
I think this should be fine, right? There was a bug in Gradle 6.something that tried to cast Providers to CollectionPropertyInternal at some point, forcing you to use Propertys, but this was fixed?
gradle-baseline-java/src/main/groovy/com/palantir/baseline/tasks/CheckJUnitDependencies.java
Outdated
Show resolved
Hide resolved
gradle-baseline-java/src/main/groovy/com/palantir/baseline/tasks/CheckJUnitDependencies.java
Outdated
Show resolved
Hide resolved
|
I validated that this works locally |
|
👍 |
|
Released 3.31.0 |
No description provided.