Fix regression in ./gradlew idea introduced in baseline 3.51.0 #1551
Conversation
Generate changelog in
|
iamdanfox
changed the title
| then: | ||
| BuildResult result = with('idea', '-Didea.active=true', '-is').build() | ||
| assert file(".idea/checkstyle-idea.xml").exists() ?: result.output | ||
| assert result.task(':idea').outcome == TaskOutcome.SUCCESS ?: result.output |
There was a problem hiding this comment.
Nice, I'm actually surprised we got this far without this test.
| private void addCopyright(node) { | ||
| def copyrightManager = node.component.find { it.'@name' == 'CopyrightManager' } | ||
| private void addCopyright(Node node) { | ||
| Node copyrightManager = node.component.find {it.'@name' == 'CopyrightManager'} |
There was a problem hiding this comment.
a lot of these changes were motivated by @CompileStatic, but I couldn't fully lock it in because of all our xml manipulation. Figured it was better to just get closer 🤷
| @@ -345,6 +351,7 @@ class BaselineIdea extends AbstractBaselinePlugin { | |||
| return | |||
| } | |||
|
|
|||
| // language=xml | |||
There was a problem hiding this comment.
One of my fav idea features.
| def copyrightDir = Paths.get("${configDir}/copyright/") | ||
| def copyrightFiles = getCopyrightFiles(copyrightDir) | ||
| copyrightFiles.each { File file -> | ||
| copyrightFiles.each {File file -> |
There was a problem hiding this comment.
these whitespace changes are intellij helpfully reformatting things. Given that we don't have a palantir-groovy-format (😂), I couldn't be bothered to revert em all piece by piece
| @@ -353,6 +360,7 @@ class BaselineIdea extends AbstractBaselinePlugin { | |||
| } | |||
|
|
|||
| private static void addInspectionProjectProfile(node) { | |||
| // language=xml | |||
There was a problem hiding this comment.
i stumbled across this trick further down this file, turns out IntelliJ can give you language-specific code highlighting for snippets!!!
| @@ -49,7 +49,23 @@ class BaselineIdeaIntegrationTest extends AbstractPluginTest { | |||
| buildFile << standardBuildFile | |||
|
|
|||
| then: | |||
| with('idea').build() | |||
There was a problem hiding this comment.
this assertion would always pass. the result contained an outcome of either success/fail, but we never checked it. 🤦
Before this PR
@dtobin reported in #dev-foundry-infra that upgrading from baseline 3.50.0 -> 3.51.0 broke
./gradlew idea.Clearly I goofed my original PR here: #1546
After this PR
==COMMIT_MSG==
Fix regression in ./gradlew idea introduced in baseline 3.51.0
==COMMIT_MSG==
I also did a publishToMavenLocal and a manual verification of this, cos I don't really trust our tests for this plugin!
Possible downsides?