Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to checkImplicitDependencies suggestion #1591

Merged
merged 3 commits into from
Dec 21, 2020

Conversation

pkoenig10
Copy link
Member

Before this PR

The checkImplicitDependencies suggestion message does not include the configuration name. This make it cumbersome for users to translate the suggestion to their Gradle configuration.

Found 1 implicit dependencies - consider adding the following explicit dependencies or avoid using classes from these jars:
    dependencies {
        'com.palantir.foo:foo'
    }

After this PR

The checkImplicitDependencies suggestion message includes the implementation configuration name. This allows users to just copy and paste the suggestion into their Gradle configuration.

Found 1 implicit dependencies - consider adding the following explicit dependencies or avoid using classes from these jars:
    dependencies {
        implementation 'com.palantir.foo:foo'
    }

@changelog-app
Copy link

changelog-app bot commented Dec 21, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The checkImplicitDependencies suggestion message now includes the implementation configuration name.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from fawind December 21, 2020 19:52
@@ -56,6 +57,7 @@ public CheckImplicitDependenciesTask() {
sourceClasses = getProject().getObjects().property(FileCollection.class);
ignore = getProject().getObjects().setProperty(String.class);
ignore.set(Collections.emptySet());
suggestionConfigurationName = getProject().getObjects().property(String.class);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether it's better to add another property or change the existing sourceClasses property to a SourceSet. I was worried that might be incorrect since that property is annotated with @Classpath.

@bulldozer-bot bulldozer-bot bot merged commit 0aaefc8 into develop Dec 21, 2020
@bulldozer-bot bulldozer-bot bot deleted the pkoenig/implicit branch December 21, 2020 20:41
@svc-autorelease
Copy link
Collaborator

Released 3.61.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants