Remove afterEvaluate from baseline immutables #1752
Conversation
Generate changelog in
|
| import org.gradle.api.tasks.compile.JavaCompile; | ||
|
|
||
| public final class BaselineImmutables implements Plugin<Project> { | ||
|
|
||
| @Override | ||
| public void apply(Project project) { | ||
| project.getPluginManager().withPlugin("java", unused -> { | ||
| project.afterEvaluate(proj -> { | ||
| proj.getConvention().getPlugin(JavaPluginConvention.class).getSourceSets().stream() |
There was a problem hiding this comment.
Calling .stream() on a DomainObjectCollection is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?
There was a problem hiding this comment.
Sounds like a great idea
There was a problem hiding this comment.
That said, we do use a .stream() below correctly....
| proj.getConvention().getPlugin(JavaPluginConvention.class).getSourceSets().stream() | ||
| .filter(sourceSet -> hasImmutablesProcessor(project, sourceSet)) | ||
| .forEach(sourceSet -> addImmutablesIncrementalCompilerArg(project, sourceSet)); | ||
| project.getExtensions().getByType(SourceSetContainer.class).configureEach(sourceSet -> { |
There was a problem hiding this comment.
Can we use .matching(...) here to keep this fluent?
There was a problem hiding this comment.
Hmm, what would we match on here?
There was a problem hiding this comment.
This is what we do in some other plugins.
There was a problem hiding this comment.
I don't think this will be as lazy as it can be, as we currently check for immutables the moment the compiler args are requested, where as with .matching on the source sets would check for immutables the earliest of when each source set is created or when configureEach is called.
Also just be aware that there's a lot of really old stuff in this repo and a lot of it is a bit dodgy (but works well enough)
There was a problem hiding this comment.
I tend to avoid fluent code because it makes the behavior less obvious to readers, especially as ordering is concerned.
There was a problem hiding this comment.
Cool, make sense. Thanks for the explanation!
|
Released 3.81.1 |
Before this PR
Thanks to @pkoenig10's hard work, we have enabled incremental compilation of immutables classes in #1750! However, it uses
afterEvaluate, which in my experience nearly always leads to pain down the road when gradle scripts get complicated and multipleafterEvaluates are run with no defined order.After this PR
==COMMIT_MSG==
Build compiler args for
com.palantir.baseline-immutablesplugin lazily to avoidafterEvaluateordering issues.==COMMIT_MSG==
Additionally add a test.
Possible downsides?