ban assert #1810
ban assert #1810
Conversation
Generate changelog in
|
|
I've intentionally opted against automatically applying the suggested fixes given how rare they are, and some subtle uses (relying on side-effects based on whether or not asserts are enabled) could be broken by automatic changes. |
| fix.replace( | ||
| tree, | ||
| String.format( | ||
| "if (!%s) { throw new IllegalStateException(%s); }", |
There was a problem hiding this comment.
These can result in funny code when the input is assert !value -> if (!!value) { throw.... Not worth optimizing here imo because we have other tools to catch and resolve those, and the fixes are only for documentation, not enabled by default.
| void testNonConstantStringDescription() { | ||
| fix().addInputLines( | ||
| "Test.java", | ||
| // format-hint |
There was a problem hiding this comment.
formatter puts all these onto one line without a well-placed comment. Some day we'll have text blocks.
|
Released 3.94.0 |
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 3.94.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Introduce `BadAssert` to ban `assert` statements in favor of better alternatives. | palantir/gradle-baseline#1810 | To enable or disable this check, please contact the maintainers of Excavator.
Before this PR
assertwas allowed.After this PR
==COMMIT_MSG==
Introduce
BadAssertto banassertstatements in favor of better alternatives.==COMMIT_MSG==
Possible downsides?
May block builds? That's rather the point.