Enable ConsistentOverrides by default #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this will automatically apply fixes for findings, which _must_ be manually reviewed relatively carefully to avoid making certain bugs less detectable. This will allow more upgrades to merge successfully and prevent _future_ bugs from merging because these are only automatically applied by baseline upgrades and when they're run manually. This change also updates the check to allow case-insensitive matching which will allow checks to pass in places that previously caused friction or required suppressions. Sometimes third party APIs use upper-camel names, and it can be difficult to fix them in a reasonable amount of time. I've never encountered such a case where two parameters had the same name with different casing. If we find such APIs, it may be best to migrate to other libraries...
Generate changelog in
|
ferozco
approved these changes
Jul 8, 2021
|
Released 3.97.0 |
This was referenced Jul 8, 2021
This was referenced Jul 8, 2021
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jul 8, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 3.97.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Enable ConsistentOverrides by default | palantir/gradle-baseline#1820 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jul 8, 2021
Merged
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this will automatically apply fixes for findings, which
must be manually reviewed relatively carefully to avoid making
certain bugs less detectable. This will allow more upgrades to
merge successfully and prevent future bugs from merging because
these are only automatically applied by baseline upgrades and
when they're run manually.
This change also updates the check to allow case-insensitive matching
which will allow checks to pass in places that previously caused
friction or required suppressions. Sometimes third party APIs
use upper-camel names, and it can be difficult to fix them in a
reasonable amount of time. I've never encountered such a case where
two parameters had the same name with different casing. If we find
such APIs, it may be best to migrate to other libraries...
==COMMIT_MSG==
Enable ConsistentOverrides by default
==COMMIT_MSG==