Plumb Add-Exports through to execution and annotation processing sites #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
force-pushed
the
ckozak/goethe
branch
from
8b3bab5
to
09d6946
Compare
carterkozak
changed the title
carterkozak
commented
Oct 29, 2021
Comment on lines
+62
to
+87
| if (project.hasProperty("add.exports.to.javac")) { | ||
| project.getExtensions().getByType(SourceSetContainer.class).configureEach(sourceSet -> { | ||
| JavaCompile javaCompile = project.getTasks() | ||
| .named(sourceSet.getCompileJavaTaskName(), JavaCompile.class) | ||
| .get(); | ||
| javaCompile | ||
| .getOptions() | ||
| .getCompilerArgumentProviders() | ||
| // Use an anonymous class because tasks with lambda inputs cannot be cached | ||
| .add(new CommandLineArgumentProvider() { | ||
| @Override | ||
| public Iterable<String> asArguments() { | ||
| // Annotation processors are executed at compile time | ||
| ImmutableList<String> arguments = | ||
| collectAnnotationProcessorExports(project, extension, sourceSet); | ||
| project.getLogger() | ||
| .debug( | ||
| "BaselineModuleJvmArgs compiling {} on {} with exports: {}", | ||
| javaCompile.getName(), | ||
| project, | ||
| arguments); | ||
| return arguments; | ||
| } | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
block is ignored for now, hopefully something becomes of gradle/gradle#18824
carterkozak
commented
Oct 29, 2021
Comment on lines
+119
to
+120
| ImmutableList<String> arguments = | ||
| collectClasspathExports(project, extension, javaExec.getClasspath()); |
There was a problem hiding this comment.
I think I'll need to duplicate this logic in sls-packaging, or figure out some other way to plumb args through
carterkozak
added a commit
to palantir/sls-packaging
that referenced
this pull request
Oct 29, 2021
This provides the same functionality as palantir/gradle-baseline#1944
carterkozak
added a commit
to palantir/jvm-diagnostics
that referenced
this pull request
Nov 2, 2021
See palantir/gradle-baseline#1944 This will allow other plugins to apply the export to jvm args without special casing this library or `java.management` specifically.
carterkozak
added a commit
to palantir/jvm-diagnostics
that referenced
this pull request
Nov 2, 2021
See palantir/gradle-baseline#1944 This will allow other plugins to apply the export to jvm args without special casing this library or `java.management` specifically.
This was referenced Nov 3, 2021
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Nov 3, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.33.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Plumb Add-Exports through to execution and annotation processing sites | palantir/gradle-baseline#1944 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Unable for jars to define the
--add-exportsoptions they need.We added this to support safepoint metrics, however it would become unnecessary if we add a way to collect manifest entries in sls-packaging: https://github.com/palantir/sls-packaging/blob/7ac5d3bef6528fe36e8dc5a249c2540b7a7023c4/gradle-sls-packaging/src/main/java/com/palantir/gradle/dist/service/tasks/LaunchConfigTask.java#L63-L67
After this PR
==COMMIT_MSG==
Plumb Add-Exports through to execution sites
==COMMIT_MSG==
sls-packaging piece here: palantir/sls-packaging#1215
Ideas how we can deduplicate that code?
Possible downsides?
It's a bit funky, we don't have a way to pass this through to IDEs aside from intellij idea with gradle integration.
We're re-purposing the
Add-Exportsmanifest entry in a way that's slightly different from how it was intended.