Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feature: Zero Warmup Guava RateLimiter (#1950)" #1957

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

carterkozak
Copy link
Contributor

This reverts commit 3219b6c.
Warmup of zero results in no rate limiting.

==COMMIT_MSG==
Revert "Feature: Zero Warmup Guava RateLimiter (#1950)"
==COMMIT_MSG==

This reverts commit 3219b6c.
Warmup of zero results in no rate limiting.
@changelog-app
Copy link

changelog-app bot commented Nov 4, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Revert "Feature: Zero Warmup Guava RateLimiter (#1950)" which results in no rate limiting

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from CRogers November 4, 2021 17:43
@bulldozer-bot bulldozer-bot bot merged commit 73998db into develop Nov 4, 2021
@bulldozer-bot bulldozer-bot bot deleted the ckozak/revert-ratelimiters branch November 4, 2021 17:48
@svc-autorelease
Copy link
Collaborator

Released 4.36.0

@pkoenig10
Copy link
Member

Guava issue describing this problem:
google/guava#2730

bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Nov 4, 2021
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.35.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Support `--add-opens` in addition to `--add-exports` | palantir/gradle-baseline#1956 |


## 4.36.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | Revert "Feature: Zero Warmup Guava RateLimiter (#1950)" which results in no rate limiting | palantir/gradle-baseline#1957 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants