Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shaded junit5 deps as excluded name #1972

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented Nov 10, 2021

Before this PR

Whenever I used @Nested with junit 5, I accidentally import org.junit.jupiter.params.shadow.com.univocity.parsers.annotations.Nested

After this PR

==COMMIT_MSG==
Stop idea recommending autocompletions from org.junit.jupiter.params.shadow
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Nov 10, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Stop idea recommending autocompletions from org.junit.jupiter.params.shadow

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 05bc20e into develop Nov 10, 2021
@bulldozer-bot bulldozer-bot bot deleted the callumr/another-shaded-pacakge branch November 10, 2021 14:29
@svc-autorelease
Copy link
Collaborator

Released 4.41.0

bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Nov 10, 2021
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.41.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | Stop idea recommending autocompletions from `org.junit.jupiter.params.shadow` | palantir/gradle-baseline#1972 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants