Allow projects to override library auto-detection #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful for test modules which aren't published, but may be consumed by either distribution code or library code.
Generate changelog in
|
carterkozak
requested review from
fawind and
CRogers
and removed request for
tetigi
fawind
approved these changes
Dec 7, 2021
|
Released 4.49.0 |
This was referenced Dec 8, 2021
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Dec 8, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.47.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Gradle plugins don't enforce PublicConstructorForAbstractClass which can break gradle injection | palantir/gradle-baseline#2009 | ## 4.48.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Disable errorprone in intellij | palantir/gradle-baseline#2010 | ## 4.49.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Allow projects to override library auto-detection | palantir/gradle-baseline#2011 | ## 4.50.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Improve coordination between java-versions and idea ipr allowing project iprs to be successfully imported | palantir/gradle-baseline#2012 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Dec 8, 2021
This was referenced Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful for test modules which aren't published, but
may be consumed by either distribution code or library code.
==COMMIT_MSG==
Allow projects to override library auto-detection
==COMMIT_MSG==
The extension property dependencies feel a bit weird becuase the javaVersions plugin is responsible for making a determination whether a module is a library or dist, but it reads the override value from the submodules
javaVersionextension.I considered splitting the pieces apart and passing the full context along to each submodule, allowing it to make the determination, but the change was much larger and ultimately I'm not convinced it was easier to follow.
Ideally we'd use some third system to tag modules as distribution/asset/library/etc and simply read that metadata, but that's well out of scope for this change :-)