prevent using logsafe Args with guava Preconditions #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
Mind linking me where this came up internally? |
carterkozak
reviewed
Mar 30, 2022
| } | ||
| } | ||
| return Description.NO_MATCH; | ||
| } else if (args.size() == 2) { |
There was a problem hiding this comment.
It might be cleanest if we merge these branches, allMatch for zero additional args (args.size() == 2) appears to do the right thing
There was a problem hiding this comment.
I tried to do that but I couldn't find a way to do it without making the rule more aggressive.
There was a problem hiding this comment.
Thoughts on this? #2166
There was a problem hiding this comment.
Thanks! I thought I tried that and many tests failed.
carterkozak
reviewed
Mar 30, 2022
carterkozak
approved these changes
Apr 1, 2022
This was referenced Apr 2, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 2, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.93.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | prevent using logsafe Args with guava Preconditions | palantir/gradle-baseline#2139 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Sometimes the wrong Preconditions is imported. This prevents one such case.
After this PR
==COMMIT_MSG==
prevent using logsafe Args with guava Preconditions
==COMMIT_MSG==
Possible downsides?
None?