prevent exceptions from being passed into Args #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Apr 6, 2022
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/LogsafeArgument.java
Outdated
Show resolved
Hide resolved
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/LogsafeArgument.java
Outdated
Show resolved
Hide resolved
Comment on lines
56
to
58
| return buildDescription(tree) | ||
| .setMessage("Args with type Throwable are not allowed.") | ||
| .build(); |
There was a problem hiding this comment.
When there's a single failure message, we can set it in the top-level @BugPattern annotation summary field, then we can return describeMatch(tree); on failure.
...eline-java/src/main/groovy/com/palantir/baseline/extensions/BaselineErrorProneExtension.java
Outdated
Show resolved
Hide resolved
|
|
||
| @AutoService(BugChecker.class) | ||
| @BugPattern( | ||
| name = "LogsafeArgument", |
There was a problem hiding this comment.
Sorry for the delay, I think we'll need to rebase and remove this line (due to the error_prone 2.11 upgrade)
Suggested change
| name = "LogsafeArgument", |
carterkozak
reviewed
Apr 6, 2022
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/LogsafeArgument.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Apr 6, 2022
baseline-error-prone/src/test/java/com/palantir/baseline/errorprone/LogsafeArgumentTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Carter Kozak <ckozak@ckozak.net>
carterkozak
approved these changes
Apr 6, 2022
|
Released 4.99.0 |
This was referenced Apr 7, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 7, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.99.0 | Type | Description | Link | | ---- | ----------- | ---- | | Feature | prevent exceptions from being passed into Args | palantir/gradle-baseline#2140 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Exceptions can be passed into SafeArg/UnsafeArg, which loses the stacktrace.
After this PR
==COMMIT_MSG==
prevent exceptions from being passed into Args
==COMMIT_MSG==
Possible downsides?
None.