LoggingDoNotLog check ensures credentials aren't logged in any form #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loggers themselves are obvious, however exception messages are less obvious and equally dangerous.
Generate changelog in
|
fawind
reviewed
Apr 19, 2022
| private static final Matcher<ExpressionTree> PRECONDITIONS_METHODS = Matchers.anyOf( | ||
| MethodMatchers.staticMethod() | ||
| .onClass("com.google.common.base.Preconditions") | ||
| .namedAnyOf("checkArgument", "checkNotNull", "checkState"), |
There was a problem hiding this comment.
Should this just be any method? E.g. there is also checkElementIndex and checkPositionIndex.
There was a problem hiding this comment.
I tried to cover the most common methods, supporting others requires a different argument index offset. Could be a future improvement to this check.
|
Released 4.108.0 |
This was referenced Apr 19, 2022
This was referenced Apr 19, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 19, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.108.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | LoggingDoNotLog check ensures credentials aren't logged in any form | palantir/gradle-baseline#2205 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loggers themselves are obvious, however exception messages are less
obvious and equally dangerous.
==COMMIT_MSG==
LoggingDoNotLog check ensures credentials aren't logged in any form
==COMMIT_MSG==