Implement class-level type variable safety validation #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future, I'll implement method type variable validation as well, but this is fairly complex.
Generate changelog in
|
fawind
reviewed
May 5, 2022
| if (type != null && !type.getTypeArguments().isEmpty()) { | ||
| List<Type> resultTypeArguments = type.getTypeArguments(); | ||
| List<TypeVariableSymbol> parameterTypes = type.tsym.getTypeParameters(); | ||
| if (parameterTypes.size() == resultTypeArguments.size()) { |
There was a problem hiding this comment.
Do you have an example of where these sizes would not be equal?
There was a problem hiding this comment.
I do not, but I’ve run into cases where generic type info is missing due to compiler optimizations, so I figured it was best not to risk it.
fawind
approved these changes
May 5, 2022
|
Released 4.127.0 |
This was referenced May 5, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
May 5, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.127.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Implement class-level type variable safety validation | palantir/gradle-baseline#2254 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Implement class-level type variable safety validation
==COMMIT_MSG==
In the future, I'll implement method type variable validation
as well, but this is fairly complex.