-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support subclass safety overrides #2289
Merged
bulldozer-bot
merged 3 commits into
develop
from
ckozak/support_subclass_safety_overrides
Jun 7, 2022
Merged
Support subclass safety overrides #2289
bulldozer-bot
merged 3 commits into
develop
from
ckozak/support_subclass_safety_overrides
Jun 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
fawind
approved these changes
Jun 7, 2022
Released 4.141.0 |
This was referenced Jun 7, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jun 7, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.141.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Trust type safety on cast results, based on validation that occurred when the type was created. | palantir/gradle-baseline#2289 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Casting from an unsafe-annotated interface to a safe-annotated interface produced
UNSAFE
data.After this PR
==COMMIT_MSG==
Trust type safety on cast results, based on validation that occurred when the type was created.
==COMMIT_MSG==
Possible downsides?
The behavior this allows breaks several of our assumptions, and may cause issues elsewhere.
However there are cases where this is reasonable that don't break any assumptions, for instance: