Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task configuration avoidance #2290

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Conversation

rzpt
Copy link
Contributor

@rzpt rzpt commented Jun 6, 2022

Before this PR

Many tasks are configured unnecessarily.

After this PR

==COMMIT_MSG==
Avoid configuring many gradle tasks
==COMMIT_MSG==

Possible downsides?

None.

@changelog-app
Copy link

changelog-app bot commented Jun 6, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Avoid configuring many gradle tasks

Check the box to generate changelog(s)

  • Generate changelog entry

@fawind
Copy link
Contributor

fawind commented Jun 8, 2022

Just referencing some docs I found useful for this. Especially the below table under "Existing vs New API overview" lists a bunch of methods that are eager and possible replacements:
https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#sec:old_vs_new_configuration_api_overview

Copy link
Contributor

@fawind fawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks for fixing those!

@bulldozer-bot bulldozer-bot bot merged commit 95f0eca into develop Jun 8, 2022
@bulldozer-bot bulldozer-bot bot deleted the task-configuration-avoidance branch June 8, 2022 16:34
@carterkozak
Copy link
Contributor

Thanks!

@svc-autorelease
Copy link
Collaborator

Released 4.143.0

This was referenced Jun 8, 2022
bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request Jun 8, 2022
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.143.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Avoid configuring many gradle tasks | palantir/gradle-baseline#2290 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants