Fix class hierarchy safe-logging error message agreement #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the safety referenced in the message did not agree with the failure.
Generate changelog in
|
carterkozak
commented
Jun 7, 2022
| @@ -1768,7 +1768,8 @@ public void testSubclassWithLenientSafety() { | |||
| "import com.palantir.logsafe.*;", | |||
| "class Test {", | |||
| " @Unsafe interface UnsafeClass {}", | |||
| " // BUG: Diagnostic contains: Dangerous type: annotated 'SAFE' but ancestors declare 'SAFE'.", | |||
There was a problem hiding this comment.
apparently I didn't read this very well and copy/pasted :-(
There was a problem hiding this comment.
Woops, also slipped through review 🙈
fawind
approved these changes
Jun 7, 2022
|
Released 4.142.0 |
This was referenced Jun 7, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jun 7, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.142.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix class hierarchy safe-logging error message agreement | palantir/gradle-baseline#2295 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the safety referenced in the message did not agree
with the failure.
==COMMIT_MSG==
Fix class hierarchy safe-logging error message agreement
==COMMIT_MSG==