Make baseline-exact-dependencies compatible with configure-on-demand #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With configure-on-demand enabled, these configurations get resolved before projectsEvaluated triggers are run. (I haven't dug in fully, but I think this is happening during task graph expansion.) Make this check more lenient if configure-on-demand is enabled.
Generate changelog in
|
|
I've tagged some folks with more historical context than myself to review |
CRogers
approved these changes
Aug 25, 2022
|
Released 4.158.0 |
This was referenced Sep 2, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Sep 2, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.154.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | The JUnits reports plugin is no longer applied by default. Test reports now use the standard output locations from Gradle conventions. | palantir/gradle-baseline#2355 | ## 4.155.0 _Automated release, no documented user facing changes_ ## 4.156.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix BaselineJavaVersion checkstyle configuration on gradle < 7.5 | palantir/gradle-baseline#2360 | ## 4.157.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Make task initialization lazier in the `junit-reports` plugin. | palantir/gradle-baseline#2364 | ## 4.158.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Make the `checkUnusedDependencies` tasks added by `baseline-exact-dependencies` compatible with Gradle's configure-on-demand feature. | palantir/gradle-baseline#2363 | ## 4.159.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Add an errorprone check and typed annotation for Javax -> Jakarta<br><br>There is a certain class of very problematic cases whereby if you have<br>a method such as the following:<br><br>```<br>myJerseyResource.register(/* this is of type Object */ object);<br>```<br><br>Then if you supply a resource which includes any `javax.ws.rs`<br>annotations on it, then those will not be registered if your Jersey<br>version is 3.x or later (and you'll only find this out at runtime).<br><br>The opposite is also true if you try to supply resources annotated<br>with `jakarta.ws.rs` to Jersey 2.x.<br><br>To address this, this commit attempts to add an errorprone check<br>which lets implementors add an annotation `@ForbidJavax` to methods<br>which have been knowingly migrated to Jakarta EE9 and cannot<br>accept legacy javax types. | palantir/gradle-baseline#2366 | ## 4.160.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Workaround to IDEA-301084 | palantir/gradle-baseline#2368 | ## 4.161.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Reverts a change introduced to baseline-java-version 4.160.0, which was causing failures on multi-project builds. | palantir/gradle-baseline#2369 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
With configure-on-demand enabled, these configurations get resolved
before projectsEvaluated triggers are run. (I haven't dug in fully,
but I think this is happening during task graph expansion.)
Make this check more lenient if configure-on-demand is enabled.
After this PR
==COMMIT_MSG==
Make the
checkUnusedDependenciestasks added bybaseline-exact-dependenciescompatible with Gradle's configure-on-demand feature.==COMMIT_MSG==
Possible downsides?
Unlikely