baseline-immutables adds required exports to the java compiler #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See immutables/immutables#1379 for more information
Generate changelog in
|
schlosna
reviewed
Sep 23, 2022
Comment on lines
24
to
+25
| private static final String IMMUTABLES = 'org.immutables:value:2.8.8' | ||
| private static final String IMMUTABLES_ANNOTATIONS = 'org.immutables:value:2.8.8:annotations' |
There was a problem hiding this comment.
Curious when we bump these to test compatibility (e.g. latest is 2.9.2)
There was a problem hiding this comment.
I ran tests with both versions, 2.9.2 seems solid where I’ve tried it, but this week has been support-heavy so I’d prefer not to tempt fate quite yet :-)
schlosna
approved these changes
Sep 23, 2022
|
Released 4.177.0 |
This was referenced Sep 27, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Sep 27, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.174.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Allow projects which don't use jdk-15 to resolve latest nullaway | palantir/gradle-baseline#2400 | ## 4.175.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix GitHub issues navigation Idea config | palantir/gradle-baseline#2403 | ## 4.176.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Error-prone is enabled in idea for uniformity with CLI compilation | palantir/gradle-baseline#2405 | ## 4.177.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | baseline-immutables adds required exports to the java compiler for compatibility with jdk-17+ | palantir/gradle-baseline#2406 | ## 4.178.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Refaster compilation uses exports matching error-prone compilation | palantir/gradle-baseline#2407 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Sep 27, 2022
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See immutables/immutables#1379 for more information
==COMMIT_MSG==
baseline-immutables adds required exports to the java compiler
==COMMIT_MSG==