Stop suggesting the save actions plugin #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
Makes sense to me. First removing this suggestion, and following up with a replacement that configures native IntelliJ "Actions on save" works nicely. |
|
Related: palantir/palantir-java-format#862 |
felixdesouza
approved these changes
Apr 6, 2023
|
Released 5.5.0 |
|
This addresses #2545 |
This was referenced Apr 6, 2023
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 6, 2023
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 5.5.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | No longer suggest the "Save Actions" IntelliJ plugin which does not work in IntelliJ 2023.1 for use with Palantir Java Format. Instead, Palantir Java Format will support the IntelliJ native "Actions on save" reformat capability in a future release. | palantir/gradle-baseline#2547 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The save actions plugin is broken in IntelliJ 2023.1. It is unmaintained and there is no official fix.
In 2021.2, IntelliJ introduced a new built in reformat on save feature.
After this PR
==COMMIT_MSG==
No longer suggest the "Save Actions" IntelliJ plugin which does not work in IntelliJ 2023.1 for use with Palantir Java Format. Instead, Palantir Java Format will support the IntelliJ native "Actions on save" reformat capability in a future release.
==COMMIT_MSG==
Possible downsides?
Why this code is in gradle-baseline rather than the palantir-java-format gradle plugin I do not understand. It's going to make fixing this issue quite a bit harder.