Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage of checkClasspathCompatible #2791

Merged

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented May 1, 2024

Before this PR

A project internally was running out of heap in CI. We did a JFR and determined that JarFile and the sheer number of InflaterInputStreams it creates was using up gigabytes of space. DataInputStream was also allocating a lot (it allocates 240+ bytes the moment you create it).

After this PR

Use JarInputStream instead, which does not appear to have the same issue.

==COMMIT_MSG==
Reduce memory usage of checkClasspathCompatible
==COMMIT_MSG==

Possible downsides?

@CRogers CRogers requested a review from felixdesouza May 1, 2024 15:13
@changelog-app
Copy link

changelog-app bot commented May 1, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Reduce memory usage of checkClasspathCompatible

Check the box to generate changelog(s)

  • Generate changelog entry

…thub.com:palantir/gradle-baseline into callumr/less-memory-for-checkClasspathCompatible
Copy link
Contributor

@felixdesouza felixdesouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bulldozer-bot bulldozer-bot bot merged commit c482c93 into develop May 1, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the callumr/less-memory-for-checkClasspathCompatible branch May 1, 2024 15:29
@svc-autorelease
Copy link
Collaborator

Released 5.52.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants