Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Error Prone ThrowError to discourage throwing Errors in production code #957

Merged
merged 5 commits into from
Oct 14, 2019
Merged

Implement Error Prone ThrowError to discourage throwing Errors in production code #957

merged 5 commits into from
Oct 14, 2019

Commits on Oct 11, 2019

  1. Implement Error Prone ThrowError to discourage throwing Errors 

    Errors are often handled poorly by libraries resulting in unexpected
behavior and resource leaks. It's not obvious that 'catch (Exception e)'
does not catch Error.

This check  is intended to be advisory - it's fine to
@SuppressWarnings("ThrowError") in certain cases, but is usually not
recommended unless you are writing a testing library that throws
AssertionError.
    @carterkozak
    carterkozak committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    a3494b5 View commit details
    Browse the repository at this point in the history

  2. Implement a suggested fix

    @carterkozak
    carterkozak committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    0dfcca6 View commit details
    Browse the repository at this point in the history

  3. Add generated changelog entries

    @carterkozak
    carterkozak committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    df5a245 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2019

  1. update readme

    @carterkozak
    carterkozak committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    6386b56 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. Update example from OOM to CNF

    @carterkozak
    carterkozak committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    027e340 View commit details
    Browse the repository at this point in the history