Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker configuration from productDependencies can fail if the service doesnt publish its docker image #299

Open
qinfchen opened this issue Jan 8, 2020 · 0 comments

Comments

@qinfchen
Copy link
Contributor

qinfchen commented Jan 8, 2020

What happened?

Improvement from #239 has an implicit assumption that every sls service being declared in the product dependency must have docker images with matching group and service name.

This line will throws the following exception even if the image is not being used.

Execution failed for task ':generateDockerCompose'.
> Could not resolve all dependencies for configuration ':docker'.
   > Could not find com.test:serviceB:0.0.0.
     Required by:
         project : > project :test-server-A

Questions:

  1. is it required for a sls service to publish a docker image that shares the same name?

  2. should this plugin throw the above exception if the docker image is not being used in the docker compose rule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant