New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement] docker configuration includes productDependencies #239
Conversation
👍 |
// docker project(path: ':foo', configuration: 'productDependencies') | ||
// } | ||
project.subprojects({ Project subproject -> | ||
subproject.getPlugins().withId("com.palantir.product-dependency-introspection", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f067071
to
d14c2d7
Compare
Does this mean product dependencies must be specified now?
|
No, that looks like a bug. Can you link the actual repro to the internal slack channel so we can poke around? |
For future reference, this was due to the root project (where we defined the |
Before this PR
Internally, many repos use this plugin in conjunction with gradle-sls-packaging. When trying to create a docker-compose.yml for ETE testing, users usually want to use versions of their product dependencies.
From sls-packaging 3.7.1 onwards, there's now a convenient way of getting access to this information.
After this PR
Repos that use
com.palantir.docker-compose
at the root andcom.palantir.sls-java-service-distribution
in a subproject will now be able to magically refer to their product dependencies when templating their docker-compose.yml files: