[fix] Don't shadow the standard gradle 'ext' field on tasks. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All Gradle Tasks (and many other things) have a special 'ext' extension, which is of type ExtraPropertiesExtension (see https://docs.gradle.org/current/javadoc/org/gradle/api/plugins/ExtensionAware.html). Previously the DockerComposeExtension was shadowing this as it was set as a field with name 'ext' on the gradle tasks created by this plugin.
|
@iamdanfox: Can you approve this? |
iamdanfox
approved these changes
Apr 24, 2019
iamdanfox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix] All Gradle Tasks (and many other things) have a special 'ext' extension,
which is of type ExtraPropertiesExtension
(see https://docs.gradle.org/current/javadoc/org/gradle/api/plugins/ExtensionAware.html).
Previously the DockerComposeExtension was shadowing this as it was set as a field
with name 'ext' on the gradle tasks created by this plugin.
Before this PR
It was not possible to set custom properties on the
generateDockerComposetask by the usualgenerateDockerCompose.ext.foo = "bar"method supported by all other Gradle tasks because theGenerateDockerComposetask had a fieldextthat contained theDockerComposeExtension.After this PR
This PR removes the
extfield onGenerateDockerComposeandDockerComposeUpand gets theDockerComposeExtensiondirectly from the project.