Output to stdout/stderr while docker-compose process is running #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
fawind
approved these changes
Sep 29, 2021
|
Released 0.30.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
In #481, we accidentally removed printing out the progress of docker-compose up as it went along. Some internal projects pull so many docker containers that when there is a docker layer cache miss, the build can go for >10 mins without output, leading Circle to kill the build.
After this PR
==COMMIT_MSG==
Ensure the progress of
docker-compose upis printing to stderr/stdout to prevent circle context deadlines being hit when pulling a large number of containers..==COMMIT_MSG==
Possible downsides?