Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker push pushes all tags #506

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Docker push pushes all tags #506

merged 2 commits into from
Nov 23, 2021

Conversation

fawind
Copy link
Contributor

@fawind fawind commented Nov 23, 2021

Before this PR

The previous behavior of docker push was to push all tags of a given image. This changed recently where docker push will just push the latest tag per default (see: moby/moby#40302, docker/cli#2220).

A bunch of users relied on having the ./gradlew dockerPush task as a default task for pushing all tags and are now no longer publishing all tags.

After this PR

The dockerPush task is now an alias for the dockerTagsPush task and will push all available tags per default.

==COMMIT_MSG==
Docker push pushes all tags
==COMMIT_MSG==

Possible downsides?

Maybe we should instead migrate all users that rely on this feature to use dockerTagsPush instead of dockerPush and keep the current behavior?

@fawind fawind requested a review from CRogers November 23, 2021 12:37
@changelog-app
Copy link

changelog-app bot commented Nov 23, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The dockerPush task is now an alias for the dockerTagsPush task and will push all available tags per default.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from robert3005 November 23, 2021 12:37
@bulldozer-bot bulldozer-bot bot merged commit db4cfe1 into develop Nov 23, 2021
@bulldozer-bot bulldozer-bot bot deleted the fw/docker-push branch November 23, 2021 15:11
@svc-autorelease
Copy link
Collaborator

Released 0.31.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants