Handle incorrectly versioned certificates in system truststore #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Similar to #168. Someone internally has this x509 cert in their system truststore issued by StrongLoop. The cert uses v3 extensions but only lists itself as being v1. Java is very strict on this:
The printed form of the cert:
After this PR
==COMMIT_MSG==
Fix errors of the form
no more data allowed for version 1 certificate
when the system truststore has incorrectly versioned X.509 certs in it.==COMMIT_MSG==
We just ignore these ones - they are not going to be the Palantir CA.
Possible downsides?