More human readable output #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpryce
force-pushed
the
more_human_readable_output
branch
from
72e5dbf
to
d35eba4
Compare
nmiyake
requested changes
Dec 21, 2021
| @@ -313,6 +320,28 @@ func (i *Log4jIdentifier) lookForMatchInTar(ctx context.Context, getTarReader ar | |||
| return archiveResult, versions, nil | |||
| } | |||
|
|
|||
| func (i *Log4jIdentifier) printDetailedHashFinding(path string, finding Finding) { | |||
| if finding&ClassFileMd5 > 0 { | |||
| i.printInfoFinding("Found JndiManager class that was an exact md5 match for a known version at %s", path) | |||
There was a problem hiding this comment.
Don't think this outputs what you want -- as currently written, I think this will output a literal %s since printInfoFinding takes message and location but prints both literally.
Either printInfoFinding should take a format string or the calls should render directly.
There was a problem hiding this comment.
I don't think this is the case as the colour library takes formatted strings and outputs e.g.:
[INFO] Found finding in what appeared to be an obfuscated jar at examples/obfuscated/2.14.1-aaaagb.jar
| } else { | ||
| output = fmt.Sprintf(cveMessage+" in file %s. log4j versions: %s. Reasons: %s", path, strings.Join(versions, ", "), strings.Join(readableReasons, ", ")) | ||
| _, _ = fmt.Fprintln(r.OutputWriter, color.YellowString("[MATCH] "+cveMessage+" in file %s. log4j versions: %s. Reasons: %s", path, strings.Join(versions, ", "), strings.Join(readableReasons, ", "))) |
There was a problem hiding this comment.
Similar to the above, this is using %s but in a Fprintln (rather than Fprintf), so think that %s will print literally.
There was a problem hiding this comment.
As above - I think the colour library is doing formatting and so we're getting the formatted strings printed out.
hpryce
force-pushed
the
more_reporting_output
branch
from
ac15dc8
to
b435e57
Compare
hpryce
force-pushed
the
more_human_readable_output
branch
from
d35eba4
to
9a184e2
Compare
|
Example running of latest version: |
nmiyake
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds much more explanation for when being invoked directly by a user, with the individual match hits coming up as info lines and then the overall summary as a match line.
Colours are used to try and make it easy to see the most important parts of the output.
Intended to address #41