Fix "--disable-flagging-jndi-lookup" flag

[nmiyake]

Flag was not properly hooked up, so specifying it had no effect.
Fixes the issue so that specifying the "--disable-flagging-jndi-lookup"
flag causes the crawl operation to properly ignore flagging issues
that are caused only by the presence of the JndiLookup class.

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Fix "--disable-flagging-jndi-lookup" flag such that specifying the flag properly ignores files that were flagged only because of the presence of the JndiLookup class.

Check the box to generate changelog(s)

• Generate changelog entry

[bmoylan]

It'd be nice if there is a simple test to confirm this, but we don't have to block on it.

[nmiyake]

Agreed -- in the ideal world we should have unit tests that test all the functionality and then integration tests that test all of the flags.

After starting to make that an excuse to push off adding the integration test, realized it's not a big deal to do so and might as well start now rather than requiring all or nothing. In doing so, uncovered an edge case, so there we go!

[bmoylan]

awesome, thanks!