Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "--disable-unknown-versions" flag #59

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Conversation

nmiyake
Copy link
Contributor

@nmiyake nmiyake commented Jan 6, 2022

Adds flag for "crawl" operation that does not output any CVEs
for which the version cannot be determined.

Adds flag for "crawl" operation that does not output any CVEs
for which the version cannot be determined.
@nmiyake nmiyake requested a review from bmoylan January 6, 2022 22:24
@changelog-app
Copy link

changelog-app bot commented Jan 6, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add "--disable-unknown-versions" flag

Adds flag for "crawl" operation that does not output any CVEs
for which the version cannot be determined.

Check the box to generate changelog(s)

  • Generate changelog entry

@nmiyake
Copy link
Contributor Author

nmiyake commented Jan 6, 2022

Looked at adding an integration test, but none of the current example archives match this case (returning an issue with an unknown version of log4j).

Adding an example that doesn't work isn't super hard, but would take long enough that I don't think it's worth doing as part of this PR. I did verify that the flag works locally.

@bulldozer-bot bulldozer-bot bot merged commit 419231d into develop Jan 6, 2022
@bulldozer-bot bulldozer-bot bot deleted the addIgnoreUnknown branch January 6, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants