Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print walk error when not nil #62

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

glynternet
Copy link
Contributor

@glynternet glynternet commented Jan 11, 2022

During the hefty rebase of #47 I accidentally left a couple of log lines in the wrong place meaning we would log an error log line whenever a nested archive would be walked.

This PR fixes up those logs by:

  • Removing error log on every nested archive walk, replacing it with the wrapping of a bubbled up error in the top level Identify method.
  • Removing the "Found finding in what appeared to be an obfuscated jar..." log line, which lives at
    i.printInfoFinding("Found finding in what appeared to be an obfuscated jar at %s", path)
    with the handling of obfuscated results. I've added an issue for handling obfuscation at nested levels.

@changelog-app
Copy link

changelog-app bot commented Jan 11, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

A small logging bug has been fixed where for nested archives, an error log line would be emitted for all results, regardless of whether there was an error or not.

Check the box to generate changelog(s)

  • Generate changelog entry

@glynternet glynternet requested review from hpryce and nmiyake and removed request for hpryce January 11, 2022 11:56
@hpryce
Copy link
Contributor

hpryce commented Jan 11, 2022

👍

@bulldozer-bot bulldozer-bot bot merged commit 3618fc4 into develop Jan 11, 2022
@bulldozer-bot bulldozer-bot bot deleted the gh/fix-invalid-error-logging branch January 11, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants