Update create-app to use FOUNDRY_TOKEN in templates (#40)

palantir · Feb 8, 2024 · bcc9be9 · bcc9be9
1 parent 139cdaf
commit bcc9be9
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 6 deletions.
diff --git a/packages/create-app/changelog/@unreleased/pr-40.v2.yml b/packages/create-app/changelog/@unreleased/pr-40.v2.yml
@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: Update create-app to use FOUNDRY_TOKEN in templates instead of FOUNDRY_SDK_AUTH_TOKEN
+  links:
+  - https://github.com/palantir/osdk-ts/pull/40
diff --git a/packages/create-app/src/__snapshots__/expected-template-next-static-export/.npmrc b/packages/create-app/src/__snapshots__/expected-template-next-static-export/.npmrc
@@ -1,2 +1,2 @@
-//example.palantirfoundry.com/artifacts/api/repositories/ri.artifacts.main.repository.fake/contents/release/npm:_authToken=${FOUNDRY_SDK_AUTH_TOKEN}
+//example.palantirfoundry.com/artifacts/api/repositories/ri.artifacts.main.repository.fake/contents/release/npm:_authToken=${FOUNDRY_TOKEN}
 @fake:registry=https://example.palantirfoundry.com/artifacts/api/repositories/ri.artifacts.main.repository.fake/contents/release/npm
diff --git a/packages/create-app/src/__snapshots__/expected-template-react/.npmrc b/packages/create-app/src/__snapshots__/expected-template-react/.npmrc
@@ -1,2 +1,2 @@
-//example.palantirfoundry.com/artifacts/api/repositories/ri.artifacts.main.repository.fake/contents/release/npm:_authToken=${FOUNDRY_SDK_AUTH_TOKEN}
+//example.palantirfoundry.com/artifacts/api/repositories/ri.artifacts.main.repository.fake/contents/release/npm:_authToken=${FOUNDRY_TOKEN}
 @fake:registry=https://example.palantirfoundry.com/artifacts/api/repositories/ri.artifacts.main.repository.fake/contents/release/npm
diff --git a/packages/create-app/src/__snapshots__/expected-template-vue/.npmrc b/packages/create-app/src/__snapshots__/expected-template-vue/.npmrc
@@ -1,2 +1,2 @@
-//example.palantirfoundry.com/artifacts/api/repositories/ri.artifacts.main.repository.fake/contents/release/npm:_authToken=${FOUNDRY_SDK_AUTH_TOKEN}
+//example.palantirfoundry.com/artifacts/api/repositories/ri.artifacts.main.repository.fake/contents/release/npm:_authToken=${FOUNDRY_TOKEN}
 @fake:registry=https://example.palantirfoundry.com/artifacts/api/repositories/ri.artifacts.main.repository.fake/contents/release/npm
diff --git a/packages/create-app/src/cli.ts b/packages/create-app/src/cli.ts
@@ -191,7 +191,7 @@ export async function cli(args: string[] = process.argv) {
     message: `Done! Run the following commands to get started:\n`
       + `\n`
       + `  \`cd ${cdRelative}\`\n`
-      + `  \`export FOUNDRY_SDK_AUTH_TOKEN=<token>\`\n`
+      + `  \`export FOUNDRY_TOKEN=<token>\`\n`
       + `  \`npm install\`\n`
       + `  \`npm run dev\``,
     style: {

diff --git a/packages/create-app/src/generate/generateNpmRc.test.ts b/packages/create-app/src/generate/generateNpmRc.test.ts
@@ -18,7 +18,7 @@ import { expect, test } from "vitest";
 import { generateNpmRc } from "./generateNpmRc.js";
 
 const expected = `
-//registry.com:_authToken=\${FOUNDRY_SDK_AUTH_TOKEN}
+//registry.com:_authToken=\${FOUNDRY_TOKEN}
 @myapp:registry=https://registry.com
 `.trimStart();
 

diff --git a/packages/create-app/src/generate/generateNpmRc.ts b/packages/create-app/src/generate/generateNpmRc.ts
@@ -22,6 +22,6 @@ export function generateNpmRc({
   osdkRegistryUrl: string;
 }): string {
   const withoutProtocol = osdkRegistryUrl.replace(/^https:\/\//, "");
-  return `//${withoutProtocol}:_authToken=\${FOUNDRY_SDK_AUTH_TOKEN}\n`
+  return `//${withoutProtocol}:_authToken=\${FOUNDRY_TOKEN}\n`
     + `${osdkPackage.split("/")[0]}:registry=${osdkRegistryUrl}\n`;
 }