Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm GH token discovery as part of createReleasePr #266

Closed
ericanderson opened this issue May 2, 2024 · 0 comments · Fixed by #354
Closed

Confirm GH token discovery as part of createReleasePr #266

ericanderson opened this issue May 2, 2024 · 0 comments · Fixed by #354
Assignees
@bryantpark04
Labels
good first issue Good for newcomers

Comments

@ericanderson
Copy link
Member

ericanderson commented May 2, 2024 •
edited
Loading

Right now it says trying but then moves on. If a later failure happens its not clear if it was due to getting the token or not. Outputting that we got the token successfully would help.
@ericanderson ericanderson added the good first issue Good for newcomers label May 9, 2024
@ericanderson ericanderson changed the title Confirm GH token discovery as part of release branch Confirm GH token discovery as part of createReleasePr May 9, 2024
@bryantpark04 bryantpark04 self-assigned this May 28, 2024
@bryantpark04 bryantpark04 mentioned this issue May 28, 2024
Merged
@bryantpark04 bryantpark04 linked a pull request May 28, 2024 that will close this issue
Log GitHub token being found in createReleasePr #354
Merged
@ssanjay1 ssanjay1 mentioned this issue Jun 13, 2024
Merged
@ssanjay1 ssanjay1 mentioned this issue Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryantpark04 bryantpark04

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log GitHub token being found in createReleasePr palantir/osdk-ts
2 participants
@ericanderson @bryantpark04