Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intellisense for aggregations and fill in more number types #43

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

ericanderson
Copy link
Member

No description provided.

@changelog-app
Copy link

changelog-app bot commented Feb 7, 2024

Generate changelog in packages/client/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix intellisense for aggregations and fill in more number types

Check the box to generate changelog(s)

  • Generate changelog entry

@@ -69,7 +73,9 @@ export interface BaseObjectSet<
// OsdkObjectFrom<K, O, PropertyKeysFrom<O, K>>
// >;

aggregateOrThrow: <const AO extends AggregateOpts<O, K, any>>(
aggregateOrThrow: <
AO extends AggregateOpts<O, K, AggregationClause<O, K>>,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change made it make suggestions again

@@ -38,7 +39,8 @@ export type AggregationClause<
K
>[P]["type"] extends "string"
? StringAggregateOption | StringAggregateOption[]
: ObjectTypePropertyDefinitionsFrom<O, K>[P]["type"] extends "double"
: ObjectTypePropertyDefinitionsFrom<O, K>[P]["type"] extends
"double" | "integer" | "float" | "decimal" | "byte" | "long" | "short"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make more types work that I suspect will work

? NumericAggregateOption | NumericAggregateOption[]
: ObjectTypePropertyDefinitionsFrom<O, K>[P]["type"];
: never;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This old one was wrong because you cant have an aggregation of { geohash: "geopoint" }. Switching to never to be more accurate.

@ericanderson ericanderson merged commit 139cdaf into main Feb 7, 2024
6 checks passed
@ericanderson ericanderson deleted the ea/fix-up-aggregations branch February 7, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants