Improve string reflowing

[dansanduleac]

Before this PR

There was a hack in Level#computeBreaks to make StringWrapper and our "no newline after assignments heuristic" (802a186) work together.

palantir-java-format/palantir-java-format/src/main/java/com/palantir/javaformat/doc/Level.java

Lines 210 to 220 in 16bb99f

	/**
	* Trick to cooperate with StringWrapper. If the value is a single element (e.g. a String), then allow it to stay on
	* this line, and rely on the StringWrapper to break it accordingly.
	*
	* <p>This is to prevent StringWrapperIntegrationTest#idemponent from breaking.
	*/
	private boolean isSingleString() {
	return !this.docs.stream().anyMatch(doc -> doc instanceof Level)
	&& this.docs.stream().filter(doc -> doc instanceof Break).count() == 1
	&& getFlat().startsWith(" \"");
	}

However, this relies on leaving a string on the assignment line, and the StringWrapper actually being able to split it, which might not be the case (if it has no whitespace, for instance). Here's an example where it failed in this way (file view)

After this PR

==COMMIT_MSG==
Reflow long strings more thoroughly, taking into account that once a string is broken, its first chunk might fit on the starting line and thus it needs to be reflowed again.
==COMMIT_MSG==

Possible downsides?

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Reflow long strings more thoroughly, taking into account that once a string is broken, its first chunk might fit on the starting line and thus it needs to be reflowed again.

Check the box to generate changelog(s)

• Generate changelog entry

[svc-autorelease]

Released 0.2.5