Fix: NON-NLS comments move before + in string concatenations
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
dansanduleac
changed the title
+ in string concatenations+ in string concatenations
carterkozak
reviewed
Oct 21, 2019
| + "field_1," //$NON-NLS-1$ | ||
| + "field_2," //$NON-NLS-1$ | ||
| + "field_3," //$NON-NLS-1$ | ||
| + "field_4"; //$NON-NLS-1$ |
carterkozak
reviewed
Oct 21, 2019
| @@ -620,6 +631,10 @@ private static int getI(Input.Token token) { | |||
| return newOps.build(); | |||
| } | |||
|
|
|||
| private static boolean isNonNlsComment(Input.Tok tokAfter) { | |||
| return tokAfter.isSlashSlashComment() && tokAfter.getText().contains("$NON-NLS"); | |||
There was a problem hiding this comment.
May be able to make this more specific, nls comments are required to start with //$NON-NLS-, even subsequent numbers, e.g.
String f() {
return "a" + "b"; //$NON-NLS-1$ //$NON-NLS-2$
}Realistically I'm not sure that makes much difference.
carterkozak
approved these changes
Oct 21, 2019
|
Released 0.2.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
NON-NLS comments after
+in chains of string concatenations are moved such that they don't follow the original string anymore.After this PR
==COMMIT_MSG==
NON-NLS comments are moved behind
+tokens in string concatenations. This is a heuristic that doesn't look at what the thing before the+is, so it might produce confusing results.==COMMIT_MSG==
Possible downsides?