Excavator: Upgrades Baseline to the latest version #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -207,8 +207,8 @@ private static FormatterService createFormatter(Optional<List<URI>> implementati | |||
| URL[] implementationUrls = implementationClassPath | |||
| .map(implementationUris -> { | |||
| log.debug("Using palantir-java-format implementation defined by URIs: {}", implementationUris); | |||
| return implementationUris.stream().map(PalantirCodeStyleManager::toUrlUnchecked).toArray( | |||
| URL[]::new); | |||
| return implementationUris.stream().map(PalantirCodeStyleManager::toUrlUnchecked).toArray(URL[] | |||
There was a problem hiding this comment.
well, this one is a bit unfortunate...
| tokenRangeSet.add(characterRangeToTokenRange( | ||
| characterRange.lowerEndpoint(), characterRange.upperEndpoint() - characterRange.lowerEndpoint())); | ||
| tokenRangeSet.add(characterRangeToTokenRange(characterRange.lowerEndpoint(), characterRange.upperEndpoint() | ||
| - characterRange.lowerEndpoint())); |
There was a problem hiding this comment.
I think having set BREAK_HERE on the levels containing binary operators might have been a bit of a mistake.
We only really want to inline things like the first string argument in a long string concatenation. We should probably limit it to just that.
| " }", | ||
| "}"); | ||
| String input = Joiner.on('\n') | ||
| .join( |
There was a problem hiding this comment.
floating method call could be inlined on the first line
dansanduleac
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
2.25.0
com.palantir-java-formatwhich is also used to determine the version used by IntelliJ.To enable or disable this check, please contact the maintainers of Excavator.