Run tests on Java 17 #613
Merged
Run tests on Java 17 #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We were only running unit-tests on Java 11 and 15. I'm cherry-picking some Java 17 related formatter fixes in a separate PR and want to get the test-setup working first.
After this PR
Run unit-tests on Java 17, 15, and 11.
Also needed to cherry-pick google/google-java-format@26adad0 in order to get tests for module formatting to pass on Java 17.
==COMMIT_MSG==
Run tests on Java 17
==COMMIT_MSG==