Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Gradle build #997

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Cleanup Gradle build #997

merged 3 commits into from
Feb 2, 2024

Conversation

shanman190
Copy link
Contributor

@shanman190 shanman190 commented Feb 1, 2024

Before this PR

The build was using some old patterns that aren't supported anymore preventing Gradle 8.x adoption.

After this PR

Possible downsides?

None.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/palantir-java-format, @shanman190! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

pluginClasspath sourceSets.main.output
compileOnly configurations.implicitDependencies
implicitDependencies 'com.diffplug.spotless:spotless-plugin-gradle'
pluginClasspath 'com.diffplug.spotless:spotless-plugin-gradle'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like to only see com.diffplug.spotless:spotless-plugin-gradle only defined once, a quick way to achieve this is by modifying the pluginClasspath configuration above to have an extendsFrom compileOnly.

Copy link
Contributor

@fawind fawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks a bunch for the clean up!

@bulldozer-bot bulldozer-bot bot merged commit 9daf880 into palantir:develop Feb 2, 2024
6 checks passed
@koppor
Copy link
Contributor

koppor commented Apr 8, 2024

@shanman190 Thank you again for the work.

I see that there is an early version of the 2.0 version of the plugin (https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-dependencies-extension.html). Can this be used in this project somehow?

@shanman190
Copy link
Contributor Author

@koppor, it might. If this project is ok with the early access version, then I don't see any harm in trying it out though to prove that it does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants