Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specdir: Use testing.TempDir instead of pkg/dirs #271

Merged
merged 1 commit into from
Sep 22, 2022
Merged

specdir: Use testing.TempDir instead of pkg/dirs #271

merged 1 commit into from
Sep 22, 2022

Conversation

tabboud
Copy link
Contributor

@tabboud tabboud commented Sep 21, 2022 •
edited by nmiyake
Loading

Simplifies the testing logic using the native testing.TempDir rather use the nmiyake/pkg/dirs pkg as a dependency

This change is Reviewable

@tabboud tabboud changed the title Use testing.TempDir instead of pkg/dirs specdir: Use testing.TempDir instead of pkg/dirs Sep 21, 2022
@bulldozer-bot bulldozer-bot bot merged commit dd6dacf into master Sep 22, 2022
@bulldozer-bot bulldozer-bot bot deleted the ta/specdir branch September 22, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmoylan bmoylan bmoylan approved these changes

Assignees
No one assigned
Labels
merge when ready no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tabboud @bmoylan