Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish develop snapshots on every commit to develop #3312

Merged
merged 1 commit into from Mar 27, 2017

Conversation

hellochar
Copy link
Contributor

Fixes #3308

Note: With our current release process, the following behavior happens:

  1. We commit a "bump version release" for e.g. v3.2.0, which triggers a dev snapshot
  2. That commit will get published as e.g. 3.1.0-6-g123abc to next
  3. Then, we create git tag v3.2.0, and publish 3.2.0 to latest (which is actually the exact same release as 3.1.0-6g123abc).

This means every latest release will be mirrored as a next release with a different version number, which is not ideal. Thoughts? @themadcreator @giladgray @aidanns

Also, on the next commit to develop, we'd publish 3.2.0-1-g-456def to next -- this means next never gets 3.2.0; they just jump from 3.1.0-6 to 3.2.0.

@adidahiya
Copy link
Contributor

This means every latest release will be mirrored as a next release with a different version number, which is not ideal.

This sounds totally fine. Multiple releases off the same commit, as long as they all adhere to semver and are predictable, are fine.

@hellochar hellochar merged commit 9dad2a3 into develop Mar 27, 2017
@hellochar hellochar deleted the xzhang/publish-dev-builds branch March 27, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants