Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize keys instead of using .toString to avoid NPE #3459

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Normalize keys instead of using .toString to avoid NPE #3459

merged 1 commit into from
Apr 18, 2018

Conversation

zerovox
Copy link
Contributor

@zerovox zerovox commented Apr 4, 2018

@themadcreator ran into an NPE where the domain contains null (and/or undefined) with Stacked Area charts

@zerovox
Copy link
Contributor Author

zerovox commented Apr 12, 2018

@giladgray care to take a look?

giladgray
giladgray approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but I don't actually know this code.

@themadcreator themadcreator merged commit 18863c8 into palantir:develop Apr 18, 2018
@themadcreator themadcreator mentioned this pull request Jun 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladgray giladgray giladgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zerovox @giladgray @themadcreator