Add 0x0 size check to canvas #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents error from being thrown when we try to invoke context.drawImage with an argument that is a 0x0 canvas. Instead we just skip the drawImage.
Add 0x0 size check to canvasDemo: quicktests | fiddle |
Test dimensions on all canvasesDemo: quicktests | fiddle |
Reuse variableDemo: quicktests | fiddle |
|
Yeah, i was considering. Might as well |
Add warning for condition that previously threw exceptionDemo: quicktests | fiddle |
cmslewis
reviewed
May 5, 2018
| btx.drawImage(originalCanvas, 0, 0); | ||
| } | ||
| } else { | ||
| console.warn("Failed to fill buffer canvas with with 0x0 canvas"); |
There was a problem hiding this comment.
@themadcreator FYI there's a duplicate word here: with with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents error from being thrown when we try to
invoke context.drawImage with an argument
that is a 0x0 canvas.
Instead we just skip the drawImage.