Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate bar label text measurer caches #3546

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

themadcreator
Copy link
Contributor

A bug exists where bar chart labels render incorrectly
when the chart is first rendered into a invalid element,
such as one with zero size or display: none style.

Since text measurement is cached, these incorrect measurements
would perist and the labels would remain broken even
if the element becomes valid for rendering.

This change correctly invalidates all the bar chart
label measurer caches, and bar labels will then
render correctly when the element becomes valid.

A bug exists where bar chart labels render incorrectly
when the chart is first rendered into a invalid element,
such as one with zero size or display: none style.

Since text measurement is cached, these incorrect measurements
would perist and the labels would remain broken even
if the element becomes valid for rendering.

This change correctly invalidates all the bar chart
label measurer caches, and bar labels will then
render correctly when the element becomes valid.
@blueprint-bot
Copy link

Invalidate bar label text measurer caches

Demo: quicktests | fiddle

@themadcreator themadcreator merged commit d0fa461 into develop Jun 1, 2020
@themadcreator themadcreator deleted the bd/invalidate-label-caches branch June 1, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants