Use lodash-es and upgrade to TS@4.4 #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-yx-wu
commented
Nov 17, 2021
| @@ -56,7 +56,7 @@ export function makeSymbolCanvasDrawStep( | |||
|
|
|||
| // check attributes and symbol type | |||
| const attrsSame = isAttributeValuesEqual(prevAttrs, attrs, ContextStyleAttrs); | |||
| const symbolGenerator = symbolAccessor(datum, index, this._dataset); | |||
| const symbolGenerator = symbolAccessor(datum, index, dataset); | |||
There was a problem hiding this comment.
I wonder why this ever worked, since the this in a browser context refers to the window object and doesn't make any sense here. Maybe a transpilation bug that is surfacing now that we've upgraded typescript?
Remove weird reference to thisDemo: quicktests | fiddle |
|
A lot of casting to |
styu
reviewed
Nov 17, 2021
adidahiya
reviewed
Nov 17, 2021
Pick instead of casting and import typeDemo: quicktests | fiddle |
michael-yx-wu
commented
Nov 17, 2021
Fix indentationDemo: quicktests | fiddle |
Remove unnecessary castingDemo: quicktests | fiddle |
michael-yx-wu
commented
Nov 17, 2021
Comment on lines
+4480
to
+4481
| lodash-es@^4.17.15: | ||
| version "4.17.15" |
There was a problem hiding this comment.
Matches our internal version
Use lodash-es@4.7.15Demo: quicktests | fiddle |
adidahiya
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.