only_has_contributors_in rule #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluekeyes
reviewed
Aug 15, 2019
There was a problem hiding this comment.
While I'm happy to support this, I think the behavior is closer to the existing has_contributor_in, so I'd like to call it only_has_contributors_in instead. The contributor logic considers the author a contributor, so the end behavior is the same.
policy/predicate/author.go
Outdated
| } | ||
|
|
||
| for _, c := range commits { | ||
| result, err := pred.IsActor(ctx, prctx, c.Author) |
There was a problem hiding this comment.
I'd suggest copying and modifying the logic from the existing HasContribtorIn predicate, as it has a few advantages:
- It properly considers both the author and the committer of a commit as contributors
- It avoids running
IsActoron the same user more than once (although the internal caching makes this less important)
bluekeyes
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case is when you have more than one set of users (or bots!) that can make pre-approved changes, all of which you want to allow to go through.
In our case, we have one bot that creates PRs, and another bot that ensures the PRs stay up to date with master. In some cases the timing works out where a PR ends up with commits from both bots before it's able to be merged. We want to allow these to push through.