Don't request reviewers if there are existing reviews #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvoboda
commented
Oct 14, 2019
| @@ -277,7 +277,7 @@ func (ghc *GitHubContext) RepositoryCollaborators() (map[string]string, error) { | |||
| return ghc.collaborators, nil | |||
| } | |||
|
|
|||
| func (ghc *GitHubContext) HasReveiwers() (bool, error) { | |||
| func (ghc *GitHubContext) HasReviewers() (bool, error) { | |||
There was a problem hiding this comment.
Also fixed a type while I was here
asvoboda
commented
Oct 14, 2019
bluekeyes
reviewed
Oct 14, 2019
There was a problem hiding this comment.
A more robust fix might be to only take action if the pull_request event is opened or ready_for_review and otherwise process the event without taking action. That should further help to avoid race conditions between server instances if there are multiple events in quick succession (say pushing and editing, or the auto-edit from something like Reviewable.)
bluekeyes
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github removes the set of users requested for review once they finish adding a review, which can cause the
HasReviewers()flow to feel pretty klunky.To fix this, we can also check if there are any reviews left on the PR, and reasonably assume that if a user has already left some reviews that the bot can safely move on.